Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0.0 fixes #7

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

10.0.0 fixes #7

wants to merge 28 commits into from

Conversation

filliph
Copy link

@filliph filliph commented Oct 28, 2022

Fix all errors caught by BugGrabber when loading the UI and browsing / clicking world quests.

Notes

  • The LFGParent fix is obviously not correct but I haven't worked out the "real fix" yet.
  • I haven't tested the settings yet. Settings appear to work fine 🙂

I really appreciate all of your hard work on this add-on. I've tried other World Quest add-ons, but they're just not the same. The level of integration this add-on offers makes it invaluable for me.

I know you're not interested in playing WoW right now, which is entirely understandable.

anarior-nz and others added 5 commits May 18, 2022 00:28
Initial fork and toc bump for 9.2
toc bump for 9.2.5
- Fix Backdrop related XML errors
- Fix HorizontalSliderTemplate -> UISliderTemplate
- Wrap LFG panel in a nil check for now
- Fix progress bar getting stuck
Removed check for GetBuildInfo() < "9.0.5" as it fails for 10.0
@lucasvienna
Copy link

@filliph I've figured out the LFGParent fix: it is now LFGListFrame.SearchPanel.ScrollBox. We can do something like:

local LFGParent = LFGListFrame.SearchPanel.ScrollBox;
if LFGParent and LFGParent.StartGroupButton then
-- ...
end

Thanks to @lucasvienna for the fix!
@filliph
Copy link
Author

filliph commented Nov 4, 2022

Added the fix, thank you!

filliph and others added 6 commits November 5, 2022 11:31
@dios-david
Copy link

Thanks @filliph ! Does this work for you with 10.0.2 (the Dragonflight launcH)?

@filliph
Copy link
Author

filliph commented Dec 3, 2022

@dios-david This fork is more up to date, it's the one I'm personally using 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants